thermal-service: Add mocks#710
Merged
kurtjd merged 1 commit intoOpenDevicePartnership:v0.2.0from Feb 10, 2026
Merged
Conversation
RobertZ2011
approved these changes
Feb 10, 2026
tullom
approved these changes
Feb 10, 2026
jerrysxie
approved these changes
Feb 10, 2026
Contributor
jerrysxie
left a comment
jerrysxie
left a comment
There was a problem hiding this comment.
Good start, for future expansion, we can consider adding data modeling to the mock so the mock can take a data model to generate different test cases.
Contributor
I've been thinking of a trait that can encapsulate this type of behaviour and also allow for easy fuzz testing. Will create an issue for this. Created #712 to track |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds mock sensor and fan to thermal service and updates the thermal
stdexample to make use of them (which simplifies the example quite a lot).Example can be tested with
cargo run --release --bin thermal.Resolves #619.